Рейтинг 5 из 5 звёзд

от Lobito inc. Янв. 20, 2014 · permalink

Hi!
Great extension, with a few minor issues.

1) The one reported by user "infinity" is caused by a simple typo:

<menuitem id="mailContext-Forward"

in your XUL should read

<menuitem id="mailContext-forward" ( F != f !)


2) Some buttons in the header of the "Message Pane" (message preview window) either have sub-buttons which are not overlayed, or Buttons (like "Reply List") which are not always displayed and thus easily overlooked.
The following are the further candidates for an overlay including your function call (NOTE that I did not include the calls to your function, because I'm not sure if all of those are really necessary, and not sure if I myself have missed soemthing!)

-----

<menuitem id="hdrReplySubButton" oncommand="MsgReplySender(event); event.stopPropagation(); RestoreFocusAfterHdrButton();"/>

--

<toolbarbutton id="hdrReplyListButton" oncommand="MsgReplyToListMessage(event);RestoreFocusAfterHdrButton();"/>

<menuitem id="hdrReplyList_ReplySubButton" oncommand="MsgReplySender(event); event.stopPropagation(); RestoreFocusAfterHdrButton();"/>

--

<toolbarbutton id="hdrFollowupButton" oncommand="MsgReplyGroup(event);RestoreFocusAfterHdrButton();"/>

<menuitem id="hdrFollowup_ReplySubButton" oncommand="MsgReplySender(event); event.stopPropagation(); RestoreFocusAfterHdrButton();"/>

-----

Perhaps those can alternatively be amended by overlaying the relevant commands (I'm quite new to extensions myself...), because I was surprised to see these two:

<toolbarbutton id="hdrReplyAllButton" oncommand="markReadOnReply();MsgReplyToAllMessage(event)" ...
and
<menuitem id="hdrReplyAll_ReplyAllSubButton" oncommand="markReadOnReply();MsgReplyToAllMessage(event)" ...

to be amended with your function call, although the GUI-elements themselves are NOT overlayed in your XUL, and I'm not sure why (the "observes"-attribute perhaps?)
BTW, these two belong together with the first candidate above (with id="hdrReplySubButton").

PS: Sorry to post this here, but the paragraph above the review form:
"Please do not post bug reports in reviews. (...) See the support section to find out where to get assistance for this add-on." would indeed make sense, if there WAS anything like a "support section" - the link only leads back to the extension's home with an page anchor named "support" that does not exist inside the HTML.

PPS: BTW, as I'm quite new to extensions myself: where did you put the long description that is showing on the website and in the extension manager? I did not find it anywhere inside your extension and also I did not find any good info about this, apart from the statement, that the "description"-element in install.rdf should not exceed one line of text...