Keychain Services Integration

Waardering 5 van 5 sterren

door darkslide op dec 14, 2011 · permalink

Great addon! I really don't understand why you commented out the support for Thunderbird... it works just as well in there and I'd say it's even more useful (who wants to type their password every time they read email?)

One minor bug is that it does not work with Thunderbird's integrated LDAP support. It seems that the built-in URI parser you used does not accept the ldaps scheme. I've replaced the functions _uri and _url in modules/MacOSKeychain.jsm with the following quick-and-dirty parsing code and it works like a charm:

function _uri (uriString) { return _url(uriString); }
function _url (urlString) {
if (!_url.parser) _url.parser = /^(https?|ftps?|irc|nntp|pop3s?|imaps?|ldaps?|afp|ssh|smb|ipps?|svn|smtps?):\/\/(?:[-a-z0-9.]+(?::[^@\s]+)?@)?([a-z0-9](?:[-a-z0-9.]*[a-z0-9])?)(:[0-9]{1,5})?(?:\/[^\s]*)?$/i;
var match = urlString.match(_url.parser);
if (!match) throw Error("Not a valid url: " + urlString);
var port = -1;
if (match[3]) port = match[3].substring(1, match[3].length);
return {
scheme: match[1],
host: match[2],
port: port,
spec: urlString
};
}