Assegnate 5 su 5 stelle

di Strim il Ott. 31, 2013 ·

Finally the add-on developer has replied to one of the last reviews here and promised to update 1.0 for TB 24.x soon. Thank to lot. While waiting for the update let me re-post the temporary solution and the diff with the fix.
(PLEASE NOTE this post most prob will be deleted by the moderators in a short time)

The ready-to-use add-on with 24.x patch is available here:
https://www.dropbox.com/s/8x4vectgzdkt0fq/color_folders-1.0.1-tb.xpi

The only introduced diff is:
$ diff -u0 colorfolders.js.original colorfolders.js

--- colorfolders.js.original 2011-08-16 02:40:09.140422300 +0400
+++ colorfolders.js 2013-10-17 01:48:30.340801400 +0400
@@ -16,2 +16,2 @@
- gFolderTreeView.getCellProperties = function(row, col, props) {
- gFolderTreeView.originalGetCellProperties(row, col, props);
+ gFolderTreeView.getCellProperties = function(row, col) {
+ var props = gFolderTreeView.originalGetCellProperties(row, col);
@@ -30 +30 @@
- props.AppendElement(aAtomService.getAtom(folderColor));
+ props += " " + folderColor;
@@ -32,0 +33 @@
+ return props;

Good luck,
Waiting for the update by the author,

Questa recensione riguarda una versione precedente (1.0) del componente aggiuntivo. 

di fisheater (Sviluppatore) il Ott. 31, 2013 ·

Hi Strim
Thanks for reposting. I got it.
Best
fisheater

Assegnate 5 su 5 stelle

di Strim il Ott. 25, 2013 ·

Dear guys,

I fixed the 1.0 version for 24.0.1 and posted the link here in reviews, so well the diffs to fix it on your own. Unfortunately these reviews were deleted by the moderators eventually.

Also, I directed the letter to the add-on author two days ago, and he has never answered :(

What can we do? Can we submit Color Folders 2 with updated sources of Color Folder 1.0 for 24.x and continue to maintain it workable there? I can do, if it does not violate the author's rights. In the Color Folders 2 we can preserve all the original links and rights, and surely the donations (if any) should go to the original author.

Questa recensione riguarda una versione precedente (1.0) del componente aggiuntivo. 

di fisheater (Sviluppatore) il Ott. 30, 2013 ·

Dear Strim and GuysThanks soooooo much for fixing the issue and trying hard to contact me.
Very sorry for not responding sooner. I do not know why but none of your messages have reached me. I just happened to feel like checking the reviews here for the first time after months to find your great work.
I would definitely like to integrate your fix with huge thanks into the Color Folder new release hopefully this weekends.
I have not had any chance to read through all your reviews and replies though (I rushed to let you know that you have reached me;-), the link to your fixed source would be somewhere in your reviews, wouldn't it?
Best
fisheater

Assegnate 5 su 5 stelle

di Strim il Ott. 19, 2013 ·

Dear guys, thank you for the warm words, and please donate to the real author of the addon, if you want.

The very small fix I did had taken not much time, and I did it 'cause I like this addon as you do!

Questa recensione riguarda una versione precedente (1.0) del componente aggiuntivo. 

Assegnate 5 su 5 stelle

di Strim il Ott. 17, 2013 ·

@jeroen1978g, @patrick:

The changes should be applied to JavaScript file within ZIP archive of the add-on: color_folders-1.0-tb.xpi\chrome\colorfolders.js. Reinstall the plugin from the modified XPI file then.

My version of the add-on with the only mentioned change + updated manifest is shared here:

https://www.dropbox.com/s/8x4vectgzdkt0fq/color_folders-1.0.1-tb.xpi

Will be great if the author appears and consolidates the changes, many thanks to him for this useful add-on.

Questa recensione riguarda una versione precedente (1.0) del componente aggiuntivo. 

Assegnate 5 su 5 stelle

di Strim il Ott. 16, 2013 ·

Nice plugin, since the author is out of reach I fixed it for 24.*. Hope it doesn't violate any copyrights to update colorfolders.js with the following diff:

$ diff -u0 colorfolders.js.original colorfolders.js

--- colorfolders.js.original 2011-08-16 02:40:09.140422300 +0400
+++ colorfolders.js 2013-10-17 01:48:30.340801400 +0400
@@ -16,2 +16,2 @@
- gFolderTreeView.getCellProperties = function(row, col, props) {
- gFolderTreeView.originalGetCellProperties(row, col, props);
+ gFolderTreeView.getCellProperties = function(row, col) {
+ var props = gFolderTreeView.originalGetCellProperties(row, col);
@@ -30 +30 @@
- props.AppendElement(aAtomService.getAtom(folderColor));
+ props += " " + folderColor;
@@ -32,0 +33 @@
+ return props;

Questa recensione riguarda una versione precedente (1.0) del componente aggiuntivo.