Mithgol the Webmaster

About me

Developer Information
Name Mithgol the Webmaster
User since Jan. 8, 2010
Number of add-ons developed 0 add-ons
Average rating of developer's add-ons Not yet rated

My Reviews

Hide Menubar

Rated 5 out of 5 stars

The extension works great. However, if the right Alt works as AltGr in your keyboard layout, then the right Alt is interpreted as Ctrl+Alt by Windows and the browser. If you feel that AltGr (right Alt) should show/hide the manubar as well as your left Alt, then you should alter the event listener (in hidemenubar.xul) accordingly:

// implement: press "alt" key to control the menubar display
window.addEventListener("keydown",
function(event) {
if (toolbar.autohide) {
if ((event.keyCode == KeyEvent.DOM_VK_ALT) && !event.shiftKey && !event.metaKey) {
toolbar._inactive = toolbar.inactive;
toolbar._altKey = true;
return;
} else if (event.keyCode != KeyEvent.DOM_VK_CONTROL) {
delete toolbar._inactive;
delete toolbar._altKey;
}
}
}
, true);
window.addEventListener("keyup",
function(event) {
if (toolbar.autohide && toolbar._altKey) {
if ((event.keyCode == KeyEvent.DOM_VK_ALT) && !event.shiftKey && !event.metaKey) {
toolbar.inactive = !toolbar._inactive;
} else if (event.keyCode != KeyEvent.DOM_VK_CONTROL) {
delete toolbar._inactive;
delete toolbar._altKey;
}
}
}
, true);

This review is for a previous version of the add-on (3.6.20100218).